Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eip2930: add payload methods for TxEip2930 #1218

Closed
wants to merge 3 commits into from
Closed

eip2930: add payload methods for TxEip2930 #1218

wants to merge 3 commits into from

Conversation

tcoratger
Copy link
Contributor

@tcoratger tcoratger mentioned this pull request Aug 30, 2024
Merged
@mattsse
Copy link
Member

mattsse commented Aug 30, 2024

looks like we need to bump msrv

@tcoratger
Copy link
Contributor Author

looks like we need to bump msrv

@mattsse done here #1219

mattsse
mattsse reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ptal @klkvr

crates/consensus/src/transaction/eip2930.rs Outdated Show resolved Hide resolved
@klkvr
Copy link
Member

klkvr commented Aug 30, 2024

hmm, not sure we need those? we already have encoded_len_with_signature and encode_with_signature which accept with_header: bool

@tcoratger
Copy link
Contributor Author

Oh that's true thanks

@tcoratger tcoratger closed this Aug 30, 2024
@tcoratger tcoratger mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @mattsse @klkvr